summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrégoire Jadi <gregoire.jadi@gmail.com>2013-02-25 17:19:57 +0100
committerGrégoire Jadi <gregoire.jadi@gmail.com>2013-02-27 13:28:11 +0100
commite4cebbe40eb6ec87314267079fd672f8c5bb115d (patch)
treef0b5d77503b1c9d807b60b8e9d197451df9dbdd6
parent0f76e8ca4261fae2ab47d1d5f869d2470861e1c2 (diff)
downloadorg-mode-e4cebbe40eb6ec87314267079fd672f8c5bb115d.tar.gz
org-contacts.el: Started to silent byte-compiler
* contrib/lisp/org-contacts.el: Remove some compile-time warnings by adding the proper declarations. (org-contacts-anniversaries): Hack around an undefined variable because I wasn't able to understand how this function works. (org-contacts-wl-get-from-header-content): Check whether the variable `wl-summary-buffer-elmo-folder' is bound or not.
-rw-r--r--contrib/lisp/org-contacts.el12
1 files changed, 10 insertions, 2 deletions
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 786650b..f99242c 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -43,6 +43,7 @@
(require 'org))
(require 'gnus-util)
(require 'org-agenda)
+(require 'org-capture)
(defgroup org-contacts nil
"Options about contacts management."
@@ -132,6 +133,11 @@ This overrides `org-email-link-description-format' if set."
:group 'org-contacts
:type 'file)
+;; Decalre external functions and variables
+(declare-function wl-summary-message-number "ext:wl-summary" ())
+(declare-function wl-address-header-extract-address "ext:wl-address")
+(declare-function wl-address-header-extract-realname "ext:wl-address")
+
(defvar org-contacts-keymap
(let ((map (make-sparse-keymap)))
(define-key map "M" 'org-contacts-view-send-email)
@@ -501,7 +507,8 @@ Format is a string matching the following format specification:
(let ((calendar-date-style 'american)
(entry ""))
(unless format (setq format org-contacts-birthday-format))
- (loop for contact in (org-contacts-filter)
+ (loop with date = nil ; FIXME: prevent a warning
+ for contact in (org-contacts-filter)
for anniv = (let ((anniv (cdr (assoc-string
(or field org-contacts-birthday-property)
(caddr contact)))))
@@ -647,7 +654,8 @@ Works from wl-summary-mode and mime-view-mode - that is while viewing email.
Depends on Wanderlust been loaded."
(with-current-buffer (org-capture-get :original-buffer)
(cond
- ((eq major-mode 'wl-summary-mode) (when wl-summary-buffer-elmo-folder
+ ((eq major-mode 'wl-summary-mode) (when (and (boundp 'wl-summary-buffer-elmo-folder)
+ wl-summary-buffer-elmo-folder)
(elmo-message-field
wl-summary-buffer-elmo-folder
(wl-summary-message-number)