summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Egli <christian.egli@alumni.ethz.ch>2010-06-08 15:13:50 +0200
committerChristian Egli <christian.egli@alumni.ethz.ch>2010-06-08 15:13:50 +0200
commite1de4db669ab033b9fbcd82391c8a69ebf92a4bc (patch)
treebd339df70a3c99db9db3df53388ff8c08c7b9e0b
parente04b71649eb598a5be9f0c2cec84e7e5a4cc6ab8 (diff)
downloadorg-mode-e1de4db669ab033b9fbcd82391c8a69ebf92a4bc.tar.gz
Avoid compiler warnings about reference to free variable `old-level'
-rw-r--r--lisp/ChangeLog5
-rw-r--r--lisp/org-taskjuggler.el19
2 files changed, 15 insertions, 9 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 99c3ec3..4d92731 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2010-06-08 Christian Egli <christian.egli@sbszh.ch>
+
+ * org-taskjuggler.el (org-export-taskjuggler-old-level):
+ define local variable to avoid compiler warning.
+
2010-06-07 Christian Egli <christian.egli@sbszh.ch>
* org-exp.el (org-export): Added taskjuggler export to the export
diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
index 5c0d4bd..f64138e 100644
--- a/lisp/org-taskjuggler.el
+++ b/lisp/org-taskjuggler.el
@@ -148,8 +148,6 @@
;; - Make sure multiple dependency definitions (i.e. BLOCKER on
;; previous-sibling and on a specific task_id) in multiple
;; attributes are properly exported.
-;; - Fix compiler warnings about reference and assignment to free
-;; variable `old-level' in org-taskjuggler-close-maybe
;;
;;; Code:
@@ -237,6 +235,9 @@ but before any resource and task declarations."
;;; Autoload functions:
+;; avoid compiler warning about free variable
+(defvar org-export-taskjuggler-old-level)
+
;;;###autoload
(defun org-export-as-taskjuggler ()
"Export parts of the current buffer as a TaskJuggler file.
@@ -271,7 +272,7 @@ defined in `org-export-taskjuggler-default-reports'."
(file-name-nondirectory buffer-file-name))
org-export-taskjuggler-extension)))
(buffer (find-file-noselect filename))
- (old-level 0)
+ (org-export-taskjuggler-old-level 0)
task resource)
(unless tasks
(error "No tasks specified"))
@@ -305,14 +306,14 @@ defined in `org-export-taskjuggler-default-reports'."
(let ((level (cdr (assoc "level" resource))))
(org-taskjuggler-close-maybe level)
(org-taskjuggler-open-resource resource)
- (setq old-level level)))
+ (setq org-export-taskjuggler-old-level level)))
(org-taskjuggler-close-maybe 1)
- (setq old-level 0)
+ (setq org-export-taskjuggler-old-level 0)
(dolist (task tasks)
(let ((level (cdr (assoc "level" task))))
(org-taskjuggler-close-maybe level)
(org-taskjuggler-open-task task)
- (setq old-level level)))
+ (setq org-export-taskjuggler-old-level level)))
(org-taskjuggler-close-maybe 1)
(org-taskjuggler-insert-reports)
(save-buffer)
@@ -630,10 +631,10 @@ org-mode priority string."
"\n"))))
(defun org-taskjuggler-close-maybe (level)
- (while (> old-level level)
+ (while (> org-export-taskjuggler-old-level level)
(insert "}\n")
- (setq old-level (1- old-level)))
- (when (= old-level level)
+ (setq org-export-taskjuggler-old-level (1- org-export-taskjuggler-old-level)))
+ (when (= org-export-taskjuggler-old-level level)
(insert "}\n")))
(defun org-taskjuggler-insert-reports ()