summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Lundin <mdl@imapmail.org>2010-09-13 20:48:27 +0000
committerCarsten Dominik <carsten.dominik@gmail.com>2011-05-02 10:08:54 +0200
commit95a8b0680e0a10b8c75d3edccc0f2751d33b18a8 (patch)
tree1e7d028f9018c9066ab567ed77f3e58728468aba
parentd8625e809f6291aaddebf605b05c54a023ee402e (diff)
downloadorg-mode-95a8b0680e0a10b8c75d3edccc0f2751d33b18a8.tar.gz
Removed unecessary invocations of org-agenda-show.
lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to prevent disrupting windows and changing point in original buffer. (org-agenda-set-property): Same (org-agenda-set-effort): Same (org-agenda-toggle-archive-tag): Same When setting a tag in the agenda, org-mode displays the corresponding entry in the original org buffer by calling org-agenda-show. This has the unwelcome side-effect of disrupting the current window arrangement and changing the position of the point in the original buffer. This behavior is inconsistent with the that of org-agenda-todo, which makes all its changes "silently." Here is the offending line (6799) in org-agenda-set-tags: --8<---------------cut here---------------start------------->8--- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed --8<---------------cut here---------------end--------------->8--- The same line occurs in org-agenda-set-property, org-agenda-set-effort, and org-agenda-toggle-archive tag.
-rw-r--r--lisp/org-agenda.el4
1 files changed, 0 insertions, 4 deletions
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index d11fdf1..65f7cea 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7296,7 +7296,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
(org-agenda-check-no-diary)
(if (and (org-region-active-p) (interactive-p))
(call-interactively 'org-change-tag-in-region)
- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
(let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
(org-agenda-error)))
(buffer (marker-buffer hdmarker))
@@ -7325,7 +7324,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
"Set a property for the current headline."
(interactive)
(org-agenda-check-no-diary)
- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
(let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
(org-agenda-error)))
(buffer (marker-buffer hdmarker))
@@ -7348,7 +7346,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
"Set the effort property for the current headline."
(interactive)
(org-agenda-check-no-diary)
- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
(let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
(org-agenda-error)))
(buffer (marker-buffer hdmarker))
@@ -7372,7 +7369,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
"Toggle the archive tag for the current entry."
(interactive)
(org-agenda-check-no-diary)
- (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
(let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
(org-agenda-error)))
(buffer (marker-buffer hdmarker))