diff options
author | Aaron Ecay <aaronecay@gmail.com> | 2015-11-07 20:11:14 +0000 |
---|---|---|
committer | Aaron Ecay <aaronecay@gmail.com> | 2015-11-07 20:31:35 +0000 |
commit | 5b76509830ec5627c4ccce7415b2ed91a6df7d23 (patch) | |
tree | cbf7f68b51f89001aca77aaba8099e785dfa113a | |
parent | f0380f54c1d002e5b70f2f179fb94445b3e25ed5 (diff) | |
download | org-mode-5b76509830ec5627c4ccce7415b2ed91a6df7d23.tar.gz |
org-lint: don’t call org-babel-process-params
* lisp/org-lint.el (org-lint-wrong-header-value): Don’t call
`org-babel-process-params'.
This function adds generated values to the header args: it’s never a
user error if these are incorrect. It also calls babel code to resolve
:var references, which makes linting an undesirably long and potentially
side-effectful operation.
-rw-r--r-- | lisp/org-lint.el | 59 |
1 files changed, 29 insertions, 30 deletions
diff --git a/lisp/org-lint.el b/lisp/org-lint.el index efbffde..37d05ed 100644 --- a/lisp/org-lint.el +++ b/lisp/org-lint.el @@ -883,36 +883,35 @@ Use :header-args: instead" (and (boundp v) (symbol-value v)))) org-babel-common-header-args-w-values)) (datum-header-values - (org-babel-process-params - (apply - #'org-babel-merge-params - org-babel-default-header-args - (and language - (let ((v (intern (concat "org-babel-default-header-args:" - language)))) - (and (boundp v) (symbol-value v)))) - (append - (list (and (memq type '(babel-call inline-babel-call)) - org-babel-default-lob-header-args)) - (progn (goto-char (org-element-property :begin datum)) - (org-babel-params-from-properties language)) - (list - (org-babel-parse-header-arguments - (org-trim - (pcase type - (`src-block - (mapconcat - #'identity - (cons (org-element-property :parameters datum) - (org-element-property :header datum)) - " ")) - (`inline-src-block - (or (org-element-property :parameters datum) "")) - (_ - (concat - (org-element-property :inside-header datum) - " " - (org-element-property :end-header datum)))))))))))) + (apply + #'org-babel-merge-params + org-babel-default-header-args + (and language + (let ((v (intern (concat "org-babel-default-header-args:" + language)))) + (and (boundp v) (symbol-value v)))) + (append + (list (and (memq type '(babel-call inline-babel-call)) + org-babel-default-lob-header-args)) + (progn (goto-char (org-element-property :begin datum)) + (org-babel-params-from-properties language)) + (list + (org-babel-parse-header-arguments + (org-trim + (pcase type + (`src-block + (mapconcat + #'identity + (cons (org-element-property :parameters datum) + (org-element-property :header datum)) + " ")) + (`inline-src-block + (or (org-element-property :parameters datum) "")) + (_ + (concat + (org-element-property :inside-header datum) + " " + (org-element-property :end-header datum))))))))))) (dolist (header datum-header-values) (let ((allowed-values (cdr (assoc-string (substring (symbol-name (car header)) 1) |