Browse Source

org.el (org-agenda-prepare-buffers): Don't use `with-silent-modifications' too early

* org.el (org-agenda-prepare-buffers): Don't use
`with-silent-modifications' too early.

Thanks to J. David Boyd for reporting this and to Florian Beck for
confirming the problem.
Bastien Guerry 7 years ago
parent
commit
109f7314a3
1 changed files with 13 additions and 15 deletions
  1. 13 15
      lisp/org.el

+ 13 - 15
lisp/org.el

@@ -17600,21 +17600,20 @@ When a buffer is unmodified, it is just killed.  When modified, it is saved
 	      (org-check-agenda-file file)
 	      (set-buffer (org-get-agenda-file-buffer file)))
 	    (widen)
+	    (org-refresh-category-properties)
+	    (org-refresh-properties org-effort-property 'org-effort)
+	    (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime)
+	    (setq org-todo-keywords-for-agenda
+		  (append org-todo-keywords-for-agenda org-todo-keywords-1))
+	    (setq org-done-keywords-for-agenda
+		  (append org-done-keywords-for-agenda org-done-keywords))
+	    (setq org-todo-keyword-alist-for-agenda
+		  (append org-todo-keyword-alist-for-agenda org-todo-key-alist))
+	    (setq org-drawers-for-agenda
+		  (append org-drawers-for-agenda org-drawers))
+	    (setq org-tag-alist-for-agenda
+		  (append org-tag-alist-for-agenda org-tag-alist))
 	    (with-silent-modifications
-	      (org-refresh-category-properties)
-	      (org-refresh-properties org-effort-property 'org-effort)
-	      (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime)
-	      (setq org-todo-keywords-for-agenda
-		    (append org-todo-keywords-for-agenda org-todo-keywords-1))
-	      (setq org-done-keywords-for-agenda
-		    (append org-done-keywords-for-agenda org-done-keywords))
-	      (setq org-todo-keyword-alist-for-agenda
-		    (append org-todo-keyword-alist-for-agenda org-todo-key-alist))
-	      (setq org-drawers-for-agenda
-		    (append org-drawers-for-agenda org-drawers))
-	      (setq org-tag-alist-for-agenda
-		    (append org-tag-alist-for-agenda org-tag-alist))
-
 	      (save-excursion
 		(remove-text-properties (point-min) (point-max) pall)
 		(when org-agenda-skip-archived-trees
@@ -17634,7 +17633,6 @@ When a buffer is unmodified, it is just killed.  When modified, it is saved
 	  (org-uniquify org-todo-keyword-alist-for-agenda)
 	  org-tag-alist-for-agenda (org-uniquify org-tag-alist-for-agenda))))
 
-
 
 ;;;; CDLaTeX minor mode